Move fully to schemer - off-board deprecated kwalify#1086
Open
simi wants to merge 2 commits into
Open
Conversation
Contributor
simi
commented
May 31, 2026
simi
commented
- first commit -> I have ported 2 stricter checks to not lower the barrier
- second commit -> removed kwalify infrastructure
Contributor
Author
|
@jasnow follow-up for #1067 (comment) |
Contributor
Author
|
@jasnow 🫡 happy to migrate also to https://github.com/jasnow/rkwalify if that's the preferred way forward now. |
jasnow
approved these changes
May 31, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
Yup, I'll offboard the update to separate PR. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
I recommend making "rake" run both (with and without the kwalify code) for a while so we see if there are any differences. The "rake" will go from
I will monitor the differences and report back to the team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.